[Backend Tester] Seed based on test name #13313
Open
+45
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13313
Note: Links to docs will display an error until the docs builds have been completed. ❌ 6 New Failures, 3 Unrelated FailuresAs of commit e7b7975 with merge base d7ecd87 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
This was referenced Aug 12, 2025
digantdesai
reviewed
Aug 12, 2025
| @@ -40,6 +41,16 @@ | |||
| } | |||
|
|
|||
|
|
|||
| def _get_test_seed(test_base_name: str) -> int: | |||
There was a problem hiding this comment.
Why not set a new, global seed every run? And print it somewhere to reproduce. Hardcoding seed ==> we will test with same random numbers every time, not sure if that's what we want.
There was a problem hiding this comment.
Update to generate a random run-wide seed and allow specifying a seed from CLI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set a manual seed for pytorch based on the test base name (test case not including flow / etc.). This makes test results stable between runs and between backends/flows. This is useful for comparing accuracy between backends, for example.
I validated this change by running convolution tests for xnnpack twice. I validated that the output accuracy statistics were identical.